Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): minor issues after PR #1881 and #1981 #1983

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix(chart): minor issues after PR #1881 and #1981 #1983

merged 1 commit into from
Oct 27, 2023

Conversation

VietND96
Copy link
Member

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fix minor issues after PR #1881 and #1981

Motivation and Context

Issue#1
From pod logs, an error could be seen, which caused pod CrashLoopBackOff after restarting multiple times

selenium-chrome-node-6966f9c8b9-q4dkg    1/3     CrashLoopBackOff

2023-10-25 19:33:44,306 INFO supervisord started with pid 7
2023-10-25 19:33:45,309 INFO spawned: 'video-recording' with pid 9
2023-10-25 19:33:45,312 INFO spawned: 'video-ready' with pid 10
mkfifo: /videos/uploadpipe: File exists
2023-10-25 19:33:45,318 INFO exited: video-recording (exit status 1; not expected)
2023-10-25 19:33:45,318 WARN received SIGINT indicating exit request

Fix: Add if condition to check pipe file existed before creating by command mkfifo

-p file
       True if file exists and is a named pipe (FIFO).

Issue#2

Checking if the display is open
/opt/bin/video.sh: line 37: xdpyinfo: command not found
Checking if node API responds

Fix: Add dependency "xdpyinfo" in the Dockerfile of video image

Issue#3

2023-10-25 20:06:45,766 CRIT Supervisor is running as root.  Privileges were not dropped because no user is specified in the config file.  If you intend to run as root, you can set user=root in the config file to avoid this message.
2023-10-25 20:06:45,769 INFO supervisord started with pid 7

Improve: Clear the redundant message from video container logs by adding user=root to Video/supervisord.conf

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Viet Nguyen Duc <[email protected]>
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VietND96!

@diemol diemol merged commit 0f7367e into SeleniumHQ:trunk Oct 27, 2023
4 checks passed
@VietND96 VietND96 changed the title Fix minor issues after PR #1881 and #1981 fix(chart): minor issues after PR #1881 and #1981 Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants